Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreamize VM subscriptions guide #3528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Dec 15, 2024

What changes are you introducing?

Upstreamizing VM subscriptions guide.

  • Updated doc title because user story is configuring virt-who for VM subscriptions, not configuring the subscriptions themselves.
  • Updated UI procedure for creating virt-who configs for Nutanix and CNV
  • Removed troubleshooting sections that duplicated troubleshooting content in Subscription Central doc, Getting started with RHEL system registration, retaining only Satellite/Foreman procedures.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-27789

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

Copy link

github-actions bot commented Dec 15, 2024

The PR preview for a43005a is available at theforeman-foreman-documentation-preview-pr-3528.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch 7 times, most recently from 4eba9e6 to 0cdf087 Compare December 16, 2024 15:11
@apinnick apinnick marked this pull request as draft December 17, 2024 11:54
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch 7 times, most recently from f0529d6 to 7905ee8 Compare December 18, 2024 15:42
@apinnick apinnick marked this pull request as ready for review December 18, 2024 15:46
@apinnick apinnick changed the title Upstreamize VM subscriptions guide (WIP) Upstreamize VM subscriptions guide Dec 18, 2024
@apinnick apinnick added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Dec 18, 2024
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from 7905ee8 to 2c90793 Compare December 18, 2024 16:04
@apinnick
Copy link
Contributor Author

@chris1984 Please review.

@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from 37f3007 to f16c7f4 Compare January 5, 2025 13:08
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! I've taken a look at a couple of top-level formalities so far. Will give it another round afterwards.

guides/common/attributes-titles.adoc Show resolved Hide resolved
guides/upstream_filename_to_satellite_link.json Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Jan 7, 2025
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from f16c7f4 to f0321f9 Compare January 9, 2025 12:13
@pr-processor pr-processor bot removed Waiting on contributor Requires an action from the author Needs re-review labels Jan 9, 2025
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from f0321f9 to f55acc9 Compare January 9, 2025 14:18
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to go more in depth with my review. This is what stood out.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments around ovirt, debugging and hammer. Overall looks pretty good

@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from f42cccf to 2e02746 Compare January 14, 2025 16:51
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from 2d499f6 to 9cb69a3 Compare January 15, 2025 08:48
@apinnick apinnick removed the Needs tech review Requires a review from the technical perspective label Jan 15, 2025
@apinnick apinnick requested a review from Lennonka January 15, 2025 12:52
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from 3be7995 to 5edb0a7 Compare January 15, 2025 16:36
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally looks good. I only have a few suggestions.
The unincluded troubleshooting ref_* files are still present in the PR. If you don't intend to include them, please remove them.

Comment on lines 92 to 102
[options="nowrap" subs="+quotes"]
----
$ hammer virt-who-config create \
--name _My_virt-who_Configuration_ \
--organizations "_My_Organization_" \
--interval 720 \ <1>
--filtering-mode none \ <2>
--hypervisor-id hostname \ <3>
--hypervisor-type libvirt \ <4>
--hypervisor-server _{foreman-example-com}_ \ <5>
--hypervisor-username virt_who_user \ <6>
--proxy '_http://proxy.example.com_:3128' \ <7>
--satellite-url _server.example.com_
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[options="nowrap" subs="+quotes"]
----
$ hammer virt-who-config create \
--name _My_virt-who_Configuration_ \
--organizations "_My_Organization_" \
--interval 720 \ <1>
--filtering-mode none \ <2>
--hypervisor-id hostname \ <3>
--hypervisor-type libvirt \ <4>
--hypervisor-server _{foreman-example-com}_ \ <5>
--hypervisor-username virt_who_user \ <6>
--proxy '_http://proxy.example.com_:3128' \ <7>
--satellite-url _server.example.com_
----
[options="nowrap" subs="+quotes,attributes"]
----
$ hammer virt-who-config create \
--name _My_virt-who_Configuration_ \
--organizations "_My_Organization_" \
--interval 720 \ <1>
--filtering-mode none \ <2>
--hypervisor-id hostname \ <3>
--hypervisor-type libvirt \ <4>
--hypervisor-server _server.example.com_ \ <5>
--hypervisor-username virt_who_user \ <6>
--proxy '_http://proxy.example.com_:3128' \ <7>
--satellite-url _{foreman-example-com}_
----

Copy link
Contributor

@Lennonka Lennonka Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apinnick These suggestions haven't been addressed. Is there a reason?

I don't think that --hypervisor-server is supposed to be Foreman/Satellite.

@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from e76af58 to 29451dd Compare January 16, 2025 08:45
@apinnick apinnick added the tech review done No issues from the technical perspective label Jan 16, 2025
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch 2 times, most recently from edf5423 to 570a7c0 Compare January 16, 2025 08:53
@apinnick apinnick force-pushed the upstreamize-vm-subscription-guide branch from 570a7c0 to 19b104d Compare January 16, 2025 08:57
@apinnick apinnick requested a review from Lennonka January 16, 2025 09:40
@apinnick
Copy link
Contributor Author

@Lennonka
Unused ref module removed.
Title fixed by deleting duplicate title attribute under "unstreamized docs".

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at it and did not find any blocking issues. I propose the following additional patch:

commit 299466c413995695e077dc2444da75e0e6d0db2e
Author: Maximilian Kolb <[email protected]>
Date:   Thu Jan 16 12:48:13 2025 +0100

    Feedback by Maximilian
    
    * Capitalize Hammer; see CONTRIBUTING.md
    * Simplify anchor/xref
    * Remove unnecessary whitespace

diff --git a/guides/common/modules/con_deploying-virt-who-configurations.adoc b/guides/common/modules/con_deploying-virt-who-configurations.adoc
index 3740f2a871..2180e858f9 100644
--- a/guides/common/modules/con_deploying-virt-who-configurations.adoc
+++ b/guides/common/modules/con_deploying-virt-who-configurations.adoc
@@ -1,8 +1,8 @@
 [id="deploying-virt-who-configurations_{context}"]
 = Deploying virt-who configurations
 
-After you create a virt-who configuration, you can download a script or copy the hammer `virt-who-config` command from the {ProjectWebUI} to deploy the configuration.
-Then, you run the script or the hammer command to install virt-who and to create local and global virt-who configuration files.
+After you create a virt-who configuration, you can download a script or copy the Hammer `virt-who-config` command from the {ProjectWebUI} to deploy the configuration.
+Then, you run the script or the Hammer command to install virt-who and to create local and global virt-who configuration files.
 
 For {oVirt}, {EL} Virtualization (KVM), and {OpenStack}, you deploy the configuration on the hypervisor specified in the file.
 
diff --git a/guides/common/modules/con_troubleshooting-virt-who.adoc b/guides/common/modules/con_troubleshooting-virt-who.adoc
index 759407943c..2656bfe787 100644
--- a/guides/common/modules/con_troubleshooting-virt-who.adoc
+++ b/guides/common/modules/con_troubleshooting-virt-who.adoc
@@ -1,6 +1,6 @@
-[id="troubleshooting-virt-who_{context}"]
+[id="troubleshooting-virt-who"]
 = Troubleshooting virt-who
 
 You can troubleshoot virt-who by checking the service status, logs, and by identifying configuration issues.
 
-For more information, see link:{RHDocsBaseURL}subscription_central/1-latest/html/getting_started_with_rhel_system_registration/adv-reg-rhel-config-vm-sub_#virt-who-troubleshooting-methods_[Virt-who troubleshooting methods] and link:{RHDocsBaseURL}subscription_central/1-latest/html/getting_started_with_rhel_system_registration/adv-reg-rhel-config-vm-sub_#virt-who-troubleshooting-scenarios_[Virt-who troubleshooting scenarios] in _Getting Started with RHEL System Registration_ in the Subscription Central documentation.
\ No newline at end of file
+For more information, see link:{RHDocsBaseURL}subscription_central/1-latest/html/getting_started_with_rhel_system_registration/adv-reg-rhel-config-vm-sub_#virt-who-troubleshooting-methods_[Virt-who troubleshooting methods] and link:{RHDocsBaseURL}subscription_central/1-latest/html/getting_started_with_rhel_system_registration/adv-reg-rhel-config-vm-sub_#virt-who-troubleshooting-scenarios_[Virt-who troubleshooting scenarios] in _Getting Started with RHEL System Registration_ in the Subscription Central documentation.
diff --git a/guides/common/modules/con_virtual-machine-subscriptions-overview.adoc b/guides/common/modules/con_virtual-machine-subscriptions-overview.adoc
index dd3b918766..b1b640f07e 100644
--- a/guides/common/modules/con_virtual-machine-subscriptions-overview.adoc
+++ b/guides/common/modules/con_virtual-machine-subscriptions-overview.adoc
@@ -1,4 +1,4 @@
-[id="virtual-machine-subscriptions-overview_{context}"]
+[id="virtual-machine-subscriptions-overview"]
 = Virtual machine subscriptions overview
 
 Virtual machines (VMs) require host-based subscriptions instead of physical subscriptions.
diff --git a/guides/common/modules/proc_checking-for-subscriptions-that-require-virt-who.adoc b/guides/common/modules/proc_checking-for-subscriptions-that-require-virt-who.adoc
index d0c050cd31..e0c74cedae 100644
--- a/guides/common/modules/proc_checking-for-subscriptions-that-require-virt-who.adoc
+++ b/guides/common/modules/proc_checking-for-subscriptions-that-require-virt-who.adoc
@@ -1,4 +1,4 @@
-[id="checking-for-subscriptions-that-require-virt-who_{context}"]
+[id="checking-for-subscriptions-that-require-virt-who"]
 = Checking for subscriptions that require virt-who
 
 You can check for subscriptions that require virt-who configuration.
diff --git a/guides/common/modules/proc_checking-virt-who-status.adoc b/guides/common/modules/proc_checking-virt-who-status.adoc
index 91f81cf234..0ef7626e21 100644
--- a/guides/common/modules/proc_checking-virt-who-status.adoc
+++ b/guides/common/modules/proc_checking-virt-who-status.adoc
@@ -1,4 +1,4 @@
-[id="checking-virt-who-status_{context}"]
+[id="checking-virt-who-status"]
 = Checking virt-who status
 
 You can check the status of virt-who by using the {ProjectWebUI} or the Hammer CLI tool.
@@ -12,8 +12,9 @@ The `OK` status indicates that virt-who is successfully connecting to {ProjectSe
 .CLI procedure
 * List the status of all virt-who instances by entering the following command on {ProjectServer}:
 +
+[options="nowrap", subs="+quotes,verbatim,attributes"]
 ----
 $ hammer virt-who-config list
 ----
 +
-The output includes the date and time when each virt-who instance reported to {ProjectServer}.
\ No newline at end of file
+The output includes the date and time when each virt-who instance reported to {ProjectServer}.
diff --git a/guides/common/modules/proc_creating-a-virt-who-configuration.adoc b/guides/common/modules/proc_creating-a-virt-who-configuration.adoc
index 2dca0bf4f1..a7d6348afc 100644
--- a/guides/common/modules/proc_creating-a-virt-who-configuration.adoc
+++ b/guides/common/modules/proc_creating-a-virt-who-configuration.adoc
@@ -1,7 +1,8 @@
-[id="creating-a-virt-who-configuration_{context}"]
+[id="creating-a-virt-who-configuration"]
 = Creating a virt-who configuration
 
-You can create a virt-who configuration by using the {ProjectWebUI} or the Hammer CLI tool.
+You can create a virt-who configuration on {Project}.
+To use the CLI instead of the {ProjectWebUI}, see the xref:cli-creating-a-virt-who-configuration[].
 
 The virt-who configuration creates a `virt_who_reporter_[id]` user with the `Virt-who Reporter` role, which provides minimal permissions for virt-who reporting to {ProjectServer}.
 This user cannot be manually configured or used to log in to {ProjectServer}.
@@ -83,6 +84,7 @@ This option provides additional AHV information when you enable both debugging o
 
 . Click *Submit*.
 
+[id="cli-creating-a-virt-who-configuration"]
 .CLI procedure
 * On {ProjectServer}, enter the `hammer virt-who-config create` command according to the following example:
 +
@@ -125,4 +127,4 @@ You cannot change `hwuuid` to another option after virt-who starts running becau
 +
 For VMware vSphere or Microsoft Hyper-V, specify the virt-who user password: `--hypervisor-password <password>`.
 <7> Optional.
---
\ No newline at end of file
+--
diff --git a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-capsule.adoc b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-capsule.adoc
index e2fb55a6c6..3e7abeb75a 100644
--- a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-capsule.adoc
+++ b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-capsule.adoc
@@ -1,4 +1,4 @@
-[id="deploying-a-virt-who-configuration-on-a-capsule_{context}"]
+[id="deploying-a-virt-who-configuration-on-a-{smart-proxy-context}-server"]
 = Deploying a virt-who configuration on a {SmartProxyServer}
 
 For VMware vSphere and Microsoft Hyper-V, you can deploy the virt-who configuration on {SmartProxyServer}.
@@ -16,21 +16,18 @@ Global configuration values apply to all virt-who configurations on the same {Sm
 ----
 $ scp _deploy_virt_who_config_1_.sh root@_{smartproxy-example-com}_:
 ----
-
 . Make the script executable:
 +
 [options="nowrap" subs="+quotes"]
 ----
 $ chmod +x _deploy_virt_who_config_1_.sh
 ----
-
 . Run the script:
 +
 [options="nowrap" subs="+quotes"]
 ----
 $ sh _deploy_virt_who_config_1_.sh
 ----
-
 . After the deployment is complete, delete the script:
 +
 [options="nowrap" subs="+quotes"]
diff --git a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-hypervisor.adoc b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-hypervisor.adoc
index 8349c4ee39..cd2259c8ad 100644
--- a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-hypervisor.adoc
+++ b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-hypervisor.adoc
@@ -19,21 +19,18 @@ Global values apply only to this hypervisor.
 ----
 $ scp _deploy_virt_who_config_1_.sh root@_hypervisor.example.com_:
 ----
-
 . Make the script executable:
 +
 [options="nowrap" subs="+quotes"]
 ----
 $ chmod +x _deploy_virt_who_config_1_.sh
 ----
-
 . Run the script:
 +
 [options="nowrap" subs="+quotes"]
 ----
 $ sh _deploy_virt_who_config_1_.sh
 ----
-
 . After the deployment is complete, delete the script:
 +
 [options="nowrap" subs="+quotes"]
diff --git a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-separate-rhel-server.adoc b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-separate-rhel-server.adoc
index edec77d469..904b35f05f 100644
--- a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-separate-rhel-server.adoc
+++ b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-a-separate-rhel-server.adoc
@@ -1,4 +1,4 @@
-[id="deploying-a-virt-who-configuration-on-a-separate-rhel-server_{context}"]
+[id="deploying-a-virt-who-configuration-on-a-separate-rhel-server"]
 = Deploying a virt-who configuration on a dedicated {EL} server
 
 For VMware vSphere, Microsoft Hyper-V, and Nutanix AHV, you can deploy the virt-who configuration on a dedicated {EL} server.
@@ -17,14 +17,12 @@ Global configuration values apply to all virt-who configurations on this server
 $ firewall-cmd --add-port="<port>/tcp" <1>
 ----
 <1> Specify `443` for VMware vCenter and Nutanix AHV. Specify `5985` for Microsoft Hyper-V.
-
 . Add a TCP port for communication between virt-who and {ProjectServer} to the permanent configuration:
 +
 [options="nowrap"]
 ----
 $ firewall-cmd --add-port="<port>/tcp" --permanent
 ----
-
 . In the {ProjectWebUI}, navigate to *Infrastructure* > *Virt-who Configurations*.
 . Click a virt-who configuration file.
 . Click the *Deploy* tab.
@@ -35,21 +33,18 @@ $ firewall-cmd --add-port="<port>/tcp" --permanent
 ----
 $ scp _deploy_virt_who_config_1_.sh root@_server.example.com_:
 ----
-
 . Make the script executable:
 +
 [options="nowrap" subs="+quotes"]
 ----
 $ chmod +x _deploy_virt_who_config_1_.sh
 ----
-
 . Run the script:
 +
 [options="nowrap" subs="+quotes"]
 ----
 $ sh _deploy_virt_who_config_1_.sh
 ----
-
 . After the deployment is complete, delete the script:
 +
 [options="nowrap" subs="+quotes"]
diff --git a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-satellite-server.adoc b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-satellite-server.adoc
index 797f478054..b02d9d8aeb 100644
--- a/guides/common/modules/proc_deploying-a-virt-who-configuration-on-satellite-server.adoc
+++ b/guides/common/modules/proc_deploying-a-virt-who-configuration-on-satellite-server.adoc
@@ -1,4 +1,4 @@
-[id="deploying-a-virt-who-configuration-on-satellite-server_{context}"]
+[id="deploying-a-virt-who-configuration-on-{project-context}-server"]
 = Deploying a virt-who configuration on {ProjectServer}
 
 For VMware vSphere and Microsoft Hyper-V, you deploy the virt-who configuration on {ProjectServer}.
diff --git a/guides/common/modules/proc_editing-a-virt-who-configuration.adoc b/guides/common/modules/proc_editing-a-virt-who-configuration.adoc
index b5379096ab..f31621ef37 100644
--- a/guides/common/modules/proc_editing-a-virt-who-configuration.adoc
+++ b/guides/common/modules/proc_editing-a-virt-who-configuration.adoc
@@ -1,4 +1,4 @@
-[id="editing-a-virt-who-configuration_{context}"]
+[id="editing-a-virt-who-configuration"]
 = Editing a virt-who configuration
 
 You can edit a virt-who configuration by using either the {ProjectWebUI} or the Hammer CLI.
@@ -9,9 +9,9 @@ You can edit a virt-who configuration by using either the {ProjectWebUI} or the
 . Edit the fields and then click *Submit*.
 . Deploy the modified virt-who configuration.
 
-[id="cli-modifying-virt-who-configuration_{context}"]
+[id="cli-editing-a-virt-who-configuration"]
 .CLI procedure
-. On {ProjectServer}, use the `hammer virt-who-config update` command to edit the virt-who configuration according to the following example:
+. On {ProjectServer}, use the `hammer virt-who-config update` command to edit the virt-who configuration:
 +
 [options="nowrap" subs="+quotes,verbatim"]
 ----
diff --git a/guides/common/modules/proc_enabling-rhsm-debug-logging.adoc b/guides/common/modules/proc_enabling-rhsm-debug-logging.adoc
index 9753a7ead8..57b235c849 100644
--- a/guides/common/modules/proc_enabling-rhsm-debug-logging.adoc
+++ b/guides/common/modules/proc_enabling-rhsm-debug-logging.adoc
@@ -1,4 +1,4 @@
-[id="enabling-rhsm-debug-logging_{context}"]
+[id="enabling-rhsm-debug-logging"]
 = Enabling debug logging
 
 You can enable debug logging for the `/var/log/rhsm/rhsm.log` file by using the {ProjectWebUI} or the Hammer CLI tool.
diff --git a/guides/common/modules/proc_removing-a-virt-who-configuration.adoc b/guides/common/modules/proc_removing-a-virt-who-configuration.adoc
index 09c0909c22..6e1522befa 100644
--- a/guides/common/modules/proc_removing-a-virt-who-configuration.adoc
+++ b/guides/common/modules/proc_removing-a-virt-who-configuration.adoc
@@ -1,4 +1,4 @@
-[id="removing-an-existing-virt-who-configuration_{context}"]
+[id="removing-an-existing-virt-who-configuration"]
 = Removing a virt-who configuration
 
 You can remove a virt-who configuration by deleting the configuration in the {ProjectWebUI} and then by deleting the configuration file from the hypervisor or the virtualization manager.
diff --git a/guides/common/modules/proc_virt-who-does-not-report-to-satellite.adoc b/guides/common/modules/proc_virt-who-does-not-report-to-satellite.adoc
index 7aff4f0266..34d0f0c323 100644
--- a/guides/common/modules/proc_virt-who-does-not-report-to-satellite.adoc
+++ b/guides/common/modules/proc_virt-who-does-not-report-to-satellite.adoc
@@ -1,4 +1,4 @@
-[id="virt-who-does-not-report-to-{project-context}-server_{context}"]
+[id="virt-who-does-not-report-to-{project-context}-server"]
 = virt-who does not report to {ProjectServer}
 
 virt-who might not report to {ProjectServer} if {ProjectServer} is configured to use a proxy server in `rhsm.conf` while virt-who is configured not to use a proxy server in `/etc/sysconfig/virt-who`.
diff --git a/guides/common/modules/ref_troubleshooting-virt-who.adoc b/guides/common/modules/ref_troubleshooting-virt-who.adoc
index f5bc91478e..7bf6f85ab3 100644
--- a/guides/common/modules/ref_troubleshooting-virt-who.adoc
+++ b/guides/common/modules/ref_troubleshooting-virt-who.adoc
@@ -1,4 +1,4 @@
-[id="virt-who-troubleshooting-methods_{context}"]
+[id="virt-who-troubleshooting-methods"]
 = Virt-who troubleshooting methods
 
 .Identifying issues when using multiple virt-who configuration files
diff --git a/guides/common/modules/ref_virt-who-configuration-examples.adoc b/guides/common/modules/ref_virt-who-configuration-examples.adoc
index 2ab4170163..0e6797b0db 100644
--- a/guides/common/modules/ref_virt-who-configuration-examples.adoc
+++ b/guides/common/modules/ref_virt-who-configuration-examples.adoc
@@ -1,4 +1,4 @@
-[id="virt-who-configuration-examples_{context}"]
+[id="virt-who-configuration-examples"]
 = Virt-who configuration examples
 
 You configure virt-who in a file that specifies details such as the virtualization type and the hypervisor or virtualization manager to query.
@@ -11,7 +11,6 @@ The `kubevirt` hypervisor is a Technology Preview.
 ====
 
 .Generic example
-
 [options="nowrap" subs="+quotes,verbatim,attributes"]
 ----
 type=libvirt <1>
@@ -30,7 +29,6 @@ rhsm_prefix=/rhsm
 <2> Read-only user that you create on the hypervisor before configuring virt-who.
 
 .{OpenStack} example
-
 [options="nowrap" subs="+quotes,verbatim,attributes"]
 ----
 type=libvirt
@@ -47,7 +45,6 @@ rhsm_prefix=/rhsm
 ----
 
 .KVM example
-
 [options="nowrap" subs="+quotes,verbatim,attributes"]
 ----
 type=libvirt
@@ -64,7 +61,6 @@ rhsm_prefix=/rhsm
 ----
 
 .vCenter Server example
-
 [options="nowrap" subs="+quotes,verbatim,attributes"]
 ----
 type=esx
@@ -81,7 +77,6 @@ rhsm_prefix=/rhsm
 ----
 
 .Nutanix AHV example
-
 [options="nowrap" subs="+quotes,verbatim,attributes"]
 ----
 type=ahv
diff --git a/guides/common/modules/ref_virt-who-configuration-overview.adoc b/guides/common/modules/ref_virt-who-configuration-overview.adoc
index 596c210c39..0231805794 100644
--- a/guides/common/modules/ref_virt-who-configuration-overview.adoc
+++ b/guides/common/modules/ref_virt-who-configuration-overview.adoc
@@ -1,4 +1,4 @@
-[id="virt-who-configuration-overview_{context}"]
+[id="virt-who-configuration-overview"]
 = virt-who configuration overview
 
 You install and configure virt-who by preparing your environment and then creating and deploying a virt-who configuration.
@@ -24,4 +24,4 @@ ifdef::satellite[]
 For more information, see {RHDocsBaseURL}subscription_central/1-latest/html/getting_started_with_the_subscriptions_service/proc-installing-satellite-inventory-upload-plugin_assembly-setting-up-subscriptionwatch-ctxt[Installing the Satellite inventory upload plugin] in _Getting Started with the Subscriptions Service_.
 endif::[]
 * Associate the virtual machines with {Project}.
-For more information, see {ManagingHostsDocURL}Associating_a_Virtual_Machine_from_a_Hypervisor_managing-hosts[Associating a virtual machine with {Project} from a hypervisor] in _{ManagingHostsDocTitle}_..
\ No newline at end of file
+For more information, see {ManagingHostsDocURL}Associating_a_Virtual_Machine_from_a_Hypervisor_managing-hosts[Associating a virtual machine with {Project} from a hypervisor] in _{ManagingHostsDocTitle}_..


For {oVirt}, {EL} Virtualization (KVM), and {OpenStack}, you deploy the configuration on the hypervisor specified in the file.

For VMware vSphere, Microsoft Hyper-V, and Nutanix AHV, you deploy the configuration on {ProjectServer}, {SmartProxyServer}, or on a dedicated {EL} server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Nutanix AHV supported as compute resource by upstream/Satellite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, probably not.

Copy link
Contributor

@Lennonka Lennonka Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as a CR but in virt-who yes? (both Jiras are private):

This is confusing? But I don't really understand this area.

hypervisor_id=hostname
owner=ORG
env=Library
server=qemu:///system <====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an open TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who knows? It has been there for years. Honestly, we can probably live without a generic OpenStack virt-who config example. 😄

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you address my comment above, we'll be ready to go.

🎉 Yaaay, for the title!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs style review Requires a review from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants